Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make users from Hosting LP devs by default with SSO #91133

Merged
merged 1 commit into from
May 24, 2024

Conversation

andregardi
Copy link
Contributor

@andregardi andregardi commented May 24, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7413

Proposed Changes

This is a follow up for #91126, in which we made users who entered the signup flow from the Hosting LP devs by default when using Continue with email option.

This PR makes it also work with Google and Apple accounts.
Users that login with Github are always considered devs by default, regardless which page started their sing up.

Testing Instructions

At the moment we are not aware of any method to test SSO on localhost or sandbox.
This is a very simple change. A code review should be enough.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/hosting-lp-is-dev-account-social-login on your sandbox.

@andregardi andregardi requested a review from a team May 24, 2024 18:06
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2024
@andregardi andregardi self-assigned this May 24, 2024
Copy link
Contributor

@JuanLucha JuanLucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect        +27 B  (+0.0%)      +13 B  (+0.0%)
accept-invite          +27 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~13 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-signup-steps-user        +27 B  (+0.0%)      +13 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@andregardi andregardi merged commit 0b32788 into trunk May 24, 2024
15 checks passed
@andregardi andregardi deleted the update/hosting-lp-is-dev-account-social-login branch May 24, 2024 18:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants