Sidebar: Fix incorrect Scheduled Updates highlight

[mmtr]

Part of https://github.com/Automattic/dotcom-forge/issues/6940

Proposed Changes

Prevents the "Plugins > Scheduled Updates" submenu from being incorrectly highlighted when visiting the Plugins Marketplace

Before	After

Why are these changes being made?

Because highlighting a submenu that is not the one for the current page is confusing

Testing Instructions

• Use the Calypso live link below
• Go to /plugins/:site for an Atomic site with the default admin interface
• Make sure the "Plugins > Add New Plugin" submenu is highlighted (no other submenus should be highlighted)
• Switch to an Atomic site with the classic admin interface
• Make sure none of the submenus are highlighted (this is expected for now, it'll be addressed by Nav Redesign: Improve Plugins menu consistency jetpack#37521)
• Go to /plugins/scheduled-updates/:site for an Atomic site with the default admin interface
• Make sure the "Plugins > Scheduled Updates" submenu is highlighted (no other submenus should be highlighted)
• Switch to an Atomic site with the classic admin interface
• Make sure the "Plugins > Scheduled Updates" submenu is highlighted (no other submenus should be highlighted)

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-0c36a433fb2815b3500df1173aca6558c70134d8

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-0c36a433fb2815b3500df1173aca6558c70134d8&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-0c36a433fb2815b3500df1173aca6558c70134d8&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~143 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
woocommerce-installation                  +54 B  (+0.0%)      +12 B  (+0.0%)
woocommerce                               +54 B  (+0.0%)      +12 B  (+0.0%)
themes                                    +54 B  (+0.0%)      +12 B  (+0.0%)
theme                                     +54 B  (+0.0%)      +12 B  (+0.0%)
subscribers                               +54 B  (+0.0%)      +12 B  (+0.0%)
stats                                     +54 B  (+0.0%)      +12 B  (+0.0%)
sites-dashboard                           +54 B  (+0.0%)      +12 B  (+0.0%)
site-purchases                            +54 B  (+0.0%)      +12 B  (+0.0%)
site-monitoring                           +54 B  (+0.0%)      +12 B  (+0.0%)
site-blocks                               +54 B  (+0.0%)      +11 B  (+0.0%)
settings-writing                          +54 B  (+0.0%)      +12 B  (+0.0%)
settings-security                         +54 B  (+0.0%)      +12 B  (+0.0%)
settings-reading                          +54 B  (+0.0%)      +12 B  (+0.0%)
settings-podcast                          +54 B  (+0.0%)      +12 B  (+0.0%)
settings-performance                      +54 B  (+0.0%)      +12 B  (+0.0%)
settings-newsletter                       +54 B  (+0.0%)      +12 B  (+0.0%)
settings-jetpack                          +54 B  (+0.0%)      +12 B  (+0.0%)
settings-discussion                       +54 B  (+0.0%)      +12 B  (+0.0%)
settings                                  +54 B  (+0.0%)      +12 B  (+0.0%)
security                                  +54 B  (+0.0%)      +12 B  (+0.0%)
scan                                      +54 B  (+0.0%)      +12 B  (+0.0%)
purchases                                 +54 B  (+0.0%)      +12 B  (+0.0%)
promote-post-i2                           +54 B  (+0.0%)      +12 B  (+0.0%)
privacy                                   +54 B  (+0.0%)      +12 B  (+0.0%)
preview                                   +54 B  (+0.0%)      +12 B  (+0.0%)
posts-custom                              +54 B  (+0.0%)      +12 B  (+0.0%)
posts                                     +54 B  (+0.0%)      +12 B  (+0.0%)
plugins                                   +54 B  (+0.0%)      +12 B  (+0.0%)
plans                                     +54 B  (+0.0%)      +12 B  (+0.0%)
people                                    +54 B  (+0.0%)      +12 B  (+0.0%)
pages                                     +54 B  (+0.0%)      +12 B  (+0.0%)
notification-settings                     +54 B  (+0.0%)      +12 B  (+0.0%)
migrate                                   +54 B  (+0.0%)      +12 B  (+0.0%)
media                                     +54 B  (+0.0%)      +12 B  (+0.0%)
me                                        +54 B  (+0.0%)      +12 B  (+0.0%)
marketplace                               +54 B  (+0.0%)      +12 B  (+0.0%)
marketing                                 +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-social                            +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-search                            +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-connect                           +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-settings                    +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-pricing                     +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-plugin-management           +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-partner-portal              +54 B  (+0.0%)      +10 B  (+0.0%)
jetpack-cloud-overview                    +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-features-comparison         +54 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-agency-sites-v2             +54 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud                             +54 B  (+0.0%)      +12 B  (+0.0%)
import                                    +54 B  (+0.0%)      +12 B  (+0.0%)
hosting                                   +54 B  (+0.0%)      +12 B  (+0.0%)
home                                      +54 B  (+0.0%)      +12 B  (+0.0%)
help                                      +54 B  (+0.0%)      +13 B  (+0.0%)
gutenberg-editor                          +54 B  (+0.0%)      +12 B  (+0.0%)
google-my-business                        +54 B  (+0.0%)      +12 B  (+0.0%)
github-deployments                        +54 B  (+0.0%)      +12 B  (+0.0%)
export                                    +54 B  (+0.0%)      +12 B  (+0.0%)
email                                     +54 B  (+0.0%)      +12 B  (+0.0%)
earn                                      +54 B  (+0.0%)      +12 B  (+0.0%)
domains                                   +54 B  (+0.0%)      +12 B  (+0.0%)
developer                                 +54 B  (+0.0%)      +12 B  (+0.0%)
dev-tools                                 +54 B  (+0.0%)      +12 B  (+0.0%)
customize                                 +54 B  (+0.0%)      +12 B  (+0.0%)
concierge                                 +54 B  (+0.0%)      +12 B  (+0.0%)
comments                                  +54 B  (+0.0%)      +12 B  (+0.0%)
checkout                                  +54 B  (+0.0%)      +12 B  (+0.0%)
backup                                    +54 B  (+0.0%)      +12 B  (+0.0%)
add-ons                                   +54 B  (+0.0%)      +12 B  (+0.0%)
activity                                  +54 B  (+0.0%)      +12 B  (+0.0%)
account-close                             +54 B  (+0.0%)      +12 B  (+0.0%)
account                                   +54 B  (+0.0%)      +12 B  (+0.0%)
a8c-for-agencies-sites                    +54 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-settings                 +54 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-referrals                +54 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-purchases                +54 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-plugins                  +54 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-partner-directory        +54 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-overview                 +54 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-migrations               +54 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-marketplace              +54 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[BogdanUngureanu]

LGTM! 🚢