Guided onboarding: align intents with existing intent system and skip goals in site-setup

[alshakero]

Fixes: 7381-gh-Automattic/dotcom-forge

Requires: D151653-code Landed.

Proposed Changes

This creates a new Stepper variant flow of site-setup called site-setup-wg that doesn't have the goals step, then redirects the users who went through Guided onboarding and declared their goals already towards it.

Why are these changes being made?

It doesn't make sense to re-ask people about their goals.

Testing Instructions

1. Go to /start/guided.
2. Answer the survey and finish the flow.
3. You should land at site-setup-wg flow.
4. Finish the flow and take note of the site.
5. All should work.

Verify intent and goals are set

1. Go to https://YOUR_NEW_SITE/wp-admin/options.php
2. Verify the intent and goals are set.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-110541

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-110541&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-110541&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~74 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +409 B  (+0.0%)      +74 B  (+0.0%)
entry-subscriptions          +39 B  (+0.0%)       +6 B  (+0.0%)
entry-main                   +39 B  (+0.0%)       +6 B  (+0.0%)
entry-login                  +39 B  (+0.0%)       +6 B  (+0.0%)
entry-domains-landing        +39 B  (+0.0%)       +6 B  (+0.0%)
entry-browsehappy            +39 B  (+0.0%)       +6 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~9637 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
site-setup-wg                  +69733 B    (new)   +14202 B    (new)
signup                           +144 B  (+0.0%)      +78 B  (+0.1%)
link-in-bio-tld-flow             +144 B  (+0.0%)      +78 B  (+0.0%)
with-theme-assembler-flow        -123 B  (-0.2%)      -30 B  (-0.3%)
update-options-flow              -123 B  (-0.3%)      -30 B  (-0.5%)
trial-wooexpress-flow            -123 B  (-0.3%)      -30 B  (-0.4%)
site-migration-flow              -123 B  (-0.2%)      -31 B  (-0.4%)
migration-signup                 -123 B  (-0.3%)      -31 B  (-0.4%)
hosted-site-migration-flow       -123 B  (-0.2%)      -31 B  (-0.4%)
free-post-setup-flow             -123 B  (-0.3%)      -29 B  (-0.5%)
free-flow                        -123 B  (-0.2%)      -29 B  (-0.3%)
entrepreneur-flow                -123 B  (-0.1%)      -30 B  (-0.1%)
assembler-first-flow             -123 B  (-0.2%)      -29 B  (-0.2%)
ai-assembler-flow                -123 B  (-0.2%)      -32 B  (-0.2%)
site-setup-flow                   -96 B  (-0.1%)     +500 B  (+3.7%)
update-design-flow                +21 B  (+0.0%)      +47 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~44 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-initial-intent                 -42 B  (-0.0%)      -16 B  (-0.0%)
async-load-signup-steps-plans-theme-preselected        -32 B  (-0.0%)      -13 B  (-0.0%)
async-load-signup-steps-plans                          -32 B  (-0.0%)      -15 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[escapemanuele]

Thanks @alshakero!

Do you believe we should get rid of the 'intent' step as well?

[escapemanuele]

@wongasy, after checkout users are redirected to the site-setup flow.

This PR removes the goals step, but after that we're seeing the intent step.
Should we skip this too? We already have the intent from the initial segmentation.

[wongasy]

but after that we're seeing the intent step.
Should we skip this too?
@escapemanuele Sorry I missed the ping! Yes, it makes sense to skip that screen as well. Since they repeat what we asked earlier in the segmentation questions.

[escapemanuele]

Thank you @wongasy, Omar is already working on making the site-setup flow use the intent from our new survey ✌️

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/site-setup-wg on your sandbox.

[agrullon95]

Tests well. Lets merge and iterate on the site-setup-wg-flow for any additional changes.