-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment Badge: add Store Sandbox dev helper #91653
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~1598 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Async-loaded Components (~14718 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
998ecbf
to
47d3216
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great! Just left a couple inline comments.
This adds a Store Sandbox dev helper to the environment badge in development and wpcalypso environments.
What is the final set of environments it should be enabled on?
Definitely it's needed in staging (though I guess you wanted to hold off on that for now until the feature is fully ready to "launch"?). For the other environments, it's clearly valuable, but they are publicly accessible and people can access those environments without being proxied, in which case the toggle won't actually work. Maybe it's good as long as we do a followup to show people the status but disable the toggle when it can't be used.
ddf9a96
to
64c55f9
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This adds a Store Sandbox dev helper to the environment badge in development and wpcalypso environments. It shows the current Store Sandbox status and allows the user to toggle Store Sandbox on/off.
Requires: D151699-code
See: https://github.com/Automattic/payments-shilling/issues/2466
Fixes: https://github.com/Automattic/payments-shilling/issues/2863
To test:
public-api.wordpress.com