Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Show referral order confirmation message. #91675

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

jkguidaven
Copy link
Contributor

Closes https://github.com/Automattic/jetpack-genesis/issues/343

Proposed Changes

  • Add Official A4A banner layout component. This is necessary to ensure consistent spacing. We will need to update any existing notifications to use the official banner layout on a separate PR.
  • Add a new hook to simplify URL query param usage that ties with UI state. This is a recurring pattern, and we need to simplify this implementation for later usage.
  • Implement the NewReferralOrderNotification component using the A4A banner layout, which will be rendered when the referral email URL query parameter is present.
  • Update the Checkout flow for the Referral purchases to redirect user with Referral email in the URL parameter.

Testing Instructions

  • Use the A4A live link and go to /marketplace/products

  • Enable 'Referral` mode.

  • Add a few items to the cart, then proceed to checkout.
    Screenshot 2024-06-11 at 8 12 27 PM

  • On the checkout page, input a referral email and request payment.
    Screenshot 2024-06-11 at 8 14 04 PM

  • Confirm that you are redirected to the Referrals dashboard with the Order confirmation.
    Screenshot 2024-06-11 at 8 14 17 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven requested a review from a team June 11, 2024 12:16
@jkguidaven jkguidaven self-assigned this Jun 11, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 11, 2024
@jkguidaven jkguidaven marked this pull request as ready for review June 11, 2024 12:17
@matticbot
Copy link
Contributor

matticbot commented Jun 11, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~17 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +61 B  (+0.0%)      +17 B  (+0.0%)
entry-main           +61 B  (+0.0%)      +17 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~366 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-referrals       +33096 B  (+7.3%)   +10650 B  (+7.5%)
a8c-for-agencies-marketplace       +374 B  (+0.1%)     +145 B  (+0.1%)
a8c-for-agencies-sites              +34 B  (+0.0%)      +25 B  (+0.0%)
a8c-for-agencies-overview           +32 B  (+0.0%)      +18 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jkguidaven jkguidaven force-pushed the add/a4a/new-refferal-order-notification branch from d94c61a to cd525b1 Compare June 11, 2024 12:42
Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@jkguidaven jkguidaven force-pushed the add/a4a/new-refferal-order-notification branch from cd525b1 to b206506 Compare June 12, 2024 06:02
@jkguidaven jkguidaven merged commit 0002f95 into trunk Jun 12, 2024
11 checks passed
@jkguidaven jkguidaven deleted the add/a4a/new-refferal-order-notification branch June 12, 2024 06:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 12, 2024
@a8ci18n
Copy link

a8ci18n commented Jun 12, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/14522650

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @jkguidaven for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 16, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants