Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reblog to repost and add a tooltip #91864

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

davemart-in
Copy link
Contributor

Description

Addresses #91811

We're going to experiment with renaming reblog to repost and adding a tooltip that says, "Repost with your thoughts" to see if these changes make it less stressful to click.

Before

POST

CleanShot 2024-06-17 at 16 54 05@2x

COMMENT

CleanShot 2024-06-17 at 16 54 24@2x

After

POST

CleanShot 2024-06-17 at 18 16 00@2x

COMMENT

CleanShot 2024-06-17 at 18 15 35@2x

Testing Instructions

  • Apply this PR
  • Head to the reader
  • Mouse over repost link in regular feed and in comments

@davemart-in davemart-in self-assigned this Jun 17, 2024
@davemart-in davemart-in requested a review from a team as a code owner June 17, 2024 22:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 17, 2024
@matticbot
Copy link
Contributor

matticbot commented Jun 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
write-flow                             -27 B  (-0.0%)      -13 B  (-0.0%)
videopress-flow                        -27 B  (-0.0%)      -13 B  (-0.0%)
reader                                 -27 B  (-0.0%)      -13 B  (-0.0%)
plugins                                -27 B  (-0.0%)      -13 B  (-0.0%)
link-in-bio-tld-flow                   -27 B  (-0.0%)      -13 B  (-0.0%)
jetpack-cloud-plugin-management        -27 B  (-0.0%)      -13 B  (-0.0%)
home                                   -27 B  (-0.0%)      -13 B  (-0.0%)
build-flow                             -27 B  (-0.0%)      -13 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~13 bytes removed 📉 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-blocks                                   -27 B  (-0.0%)      -13 B  (-0.0%)
async-load-calypso-components-web-preview-component        -27 B  (-0.0%)      -13 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@eoigal eoigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should update the popup too?

Screenshot 2024-06-18 at 10 11 01

@davemart-in
Copy link
Contributor Author

Do you think we should update the popup too?

Ah, yes...

Updated in 42f9600

Copy link
Contributor

@eoigal eoigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine and lgtm

@davemart-in davemart-in merged commit 8d19dde into trunk Jun 19, 2024
11 checks passed
@davemart-in davemart-in deleted the update/reblog-to-repost branch June 19, 2024 12:24
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 19, 2024
@a8ci18n
Copy link

a8ci18n commented Jun 19, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/14933991

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @davemart-in for including a screenshot in the description! This is really helpful for our translators.

@davemart-in davemart-in restored the update/reblog-to-repost branch June 20, 2024 20:00
@a8ci18n
Copy link

a8ci18n commented Jun 26, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants