-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sign Up page for logged in users #91958
base: trunk
Are you sure you want to change the base?
Conversation
This weird state is possible (even for WooCommerce). Nevertheless this commit allow us to customize this weird but possible step.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~207 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~68 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~92 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍, worked as described.
Related to A8C-DSP repo's issue 1880.
Previously similar changes were applied in #91095.
Related design in Figma.
Proposed Changes
Why are these changes being made?
We can open a Sign Up link while being logged in. Even though logically, it should be the same screen as Sign In for logged in users but it is not. Since that I have to customize this edge case as well.
Testing Instructions
generate-links.js
with following content:node generate-links.js
Pre-merge Checklist