Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Update suggestions and select options are sorted in Alphabetical order. #92004

Merged

Conversation

jkguidaven
Copy link
Contributor

@jkguidaven jkguidaven commented Jun 20, 2024

This PR improves the Partner directory forms by sorting select options to be in alphabetical order.

Before After
Screenshot 2024-06-21 at 1 00 32 AM Screenshot 2024-06-21 at 1 00 10 AM

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/706

Proposed Changes

  • Update suggestions and select options are sorted in Alphabetical order.

Testing Instructions

  • Use the A4A live link and go to the /partner-directory/dashboard page
  • Test both expertise and details and confirm that all selector components have options sorted in Alphabetical order.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven self-assigned this Jun 20, 2024
@jkguidaven jkguidaven requested a review from a team June 20, 2024 16:59
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 20, 2024
@jkguidaven jkguidaven marked this pull request as ready for review June 20, 2024 17:02
@matticbot
Copy link
Contributor

matticbot commented Jun 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~9 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-partner-directory        +14 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jkguidaven jkguidaven force-pushed the fix/a4a/partner-directory-pre-selection-options-ordering branch from fef125c to 0ed9f07 Compare June 21, 2024 09:43
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a/partner-directory-pre-selection-options-ordering on your sandbox.

Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'll merge it

@cleacos cleacos merged commit c8761f6 into trunk Jun 21, 2024
11 checks passed
@cleacos cleacos deleted the fix/a4a/partner-directory-pre-selection-options-ordering branch June 21, 2024 11:35
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants