Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blaze Pro from apply global font family #92006

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

lupus2k
Copy link
Contributor

@lupus2k lupus2k commented Jun 20, 2024

Slack: p1718907547394219-slack-C06DN6QQVAQ

Proposed Changes

Move the font-family inside .blaze-pro, .is-blaze-pro {

Before After
image image

Why are these changes being made?

The font was applied globally

Testing Instructions

  • Using a Classic interface site
  • Go to a Calypso (Hosting) page and one in wp-admin
  • Check the masterbar font on both pages

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@lupus2k lupus2k requested review from davemart-in and a team June 20, 2024 18:52
@lupus2k lupus2k self-assigned this Jun 20, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 20, 2024
Copy link

github-actions bot commented Jun 20, 2024

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@lupus2k lupus2k merged commit e566e8f into trunk Jun 20, 2024
7 of 8 checks passed
@lupus2k lupus2k deleted the fix/blaze-pro-font-style branch June 20, 2024 22:22
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants