Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Giropay from Calypso #92099

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Remove Giropay from Calypso #92099

merged 7 commits into from
Jun 27, 2024

Conversation

jjchrisdiehl
Copy link
Contributor

@jjchrisdiehl jjchrisdiehl commented Jun 25, 2024

Giropay is no longer supported by Stripe and we will need to remove it as a payment option as soon as possible - see thread pbUcTB-4VJ-p2

This is a follow up to the backend changes at https://github.com/Automattic/payments-shilling/issues/2933

Testing Instructions

Before checking this PR out, run through the following on production:

  • Open this file fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Snqzva%2Qcyhtvaf%2Sjcpbz%2Qovyyvat%2Spynff.jcpbz%2Qnyybjrq%2Qcnlzrag%2Qzrgubqf.cuc%3Se%3Q7nrp3r0q-og on your sandbox and change both $geo_country_code and $tax_country_code (lines 6 and 7, respectively) to 'DE'.
    public ?string $geo_country_code = 'DE';
    public ?string $tax_country_code = 'DE';

  • Save the file. This will set Checkout to allow German local methods without enabling Giropay explicitly.

  • Sandbox the api

  • Add an item to your shopping cart and continue to Checkout

  • Click on your payment methods

  • Giropay should show as a payment method

Now checkout this branch and repeat the above steps

  • In this case Giropay should not show as an option

@jjchrisdiehl jjchrisdiehl self-assigned this Jun 25, 2024
@jjchrisdiehl jjchrisdiehl requested a review from a team as a code owner June 25, 2024 22:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 25, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/giropay-from-calypso on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~628 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
checkout                          -2979 B  (-0.2%)     -303 B  (-0.1%)
site-purchases                    -2967 B  (-0.2%)     -347 B  (-0.1%)
purchases                         -2967 B  (-0.1%)     -347 B  (-0.1%)
jetpack-cloud-partner-portal       -182 B  (-0.0%)      -33 B  (-0.0%)
a8c-for-agencies-purchases         -182 B  (-0.0%)      -33 B  (-0.0%)
a8c-for-agencies-client            -182 B  (-0.0%)      -33 B  (-0.0%)
plugins                             -18 B  (-0.0%)      -11 B  (-0.0%)
media                               -18 B  (-0.0%)      -11 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~314 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal                                            -2979 B  (-0.3%)     -303 B  (-0.1%)
async-load-calypso-blocks-editor-checkout-modal                                       -2979 B  (-0.3%)     -303 B  (-0.1%)
async-load-signup-steps-page-picker                                                    -182 B  (-0.0%)      -33 B  (-0.0%)
async-load-purchase-modal-wrapper                                                      -182 B  (-0.1%)      -33 B  (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       -182 B  (-0.1%)      -33 B  (-0.0%)
async-load-design-playground                                                            -18 B  (-0.0%)      -11 B  (-0.0%)
async-load-design-blocks                                                                -18 B  (-0.0%)      -11 B  (-0.0%)
async-load-design                                                                       -18 B  (-0.0%)      -11 B  (-0.0%)
async-load-calypso-post-editor-media-modal                                              -18 B  (-0.0%)      -11 B  (-0.0%)
async-load-calypso-post-editor-editor-media-modal                                       -18 B  (-0.0%)      -11 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I wasn't able to find any other references to Giropay in the codebase, and tested that everything still looks correct with existing Giropay subscriptions.

We'll need to wait until D153365-code is deployed to merge this.

Copy link
Collaborator

@JessBoctor JessBoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 D153365-code has been deployed, merge whenever you're ready.

@jjchrisdiehl jjchrisdiehl merged commit 044e760 into trunk Jun 27, 2024
18 checks passed
@jjchrisdiehl jjchrisdiehl deleted the remove/giropay-from-calypso branch June 27, 2024 19:29
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 27, 2024
arcangelini pushed a commit that referenced this pull request Jun 28, 2024
* Remove giropay from svn_ignore_paths

* Remove giropay from PaymentLogo component

* Remove giropay from paymentMethodName func

* Remove giropay from paymentProcessors memo

* Remove giropay creation hook

* Remove giropay from class translation function

* Remove Giropay from wpcom-checkout dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants