-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Giropay from Calypso #92099
Remove Giropay from Calypso #92099
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~628 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~314 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I wasn't able to find any other references to Giropay in the codebase, and tested that everything still looks correct with existing Giropay subscriptions.
We'll need to wait until D153365-code is deployed to merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 D153365-code has been deployed, merge whenever you're ready.
* Remove giropay from svn_ignore_paths * Remove giropay from PaymentLogo component * Remove giropay from paymentMethodName func * Remove giropay from paymentProcessors memo * Remove giropay creation hook * Remove giropay from class translation function * Remove Giropay from wpcom-checkout dir
Giropay is no longer supported by Stripe and we will need to remove it as a payment option as soon as possible - see thread pbUcTB-4VJ-p2
This is a follow up to the backend changes at https://github.com/Automattic/payments-shilling/issues/2933
Testing Instructions
Before checking this PR out, run through the following on production:
Open this file fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Snqzva%2Qcyhtvaf%2Sjcpbz%2Qovyyvat%2Spynff.jcpbz%2Qnyybjrq%2Qcnlzrag%2Qzrgubqf.cuc%3Se%3Q7nrp3r0q-og on your sandbox and change both
$geo_country_code
and$tax_country_code
(lines 6 and 7, respectively) to 'DE'.public ?string $geo_country_code = 'DE';
public ?string $tax_country_code = 'DE';
Save the file. This will set Checkout to allow German local methods without enabling Giropay explicitly.
Sandbox the api
Add an item to your shopping cart and continue to Checkout
Click on your payment methods
Giropay should show as a payment method
Now checkout this branch and repeat the above steps