Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CSS #79

Merged
merged 1 commit into from
Feb 11, 2016
Merged

Remove unused CSS #79

merged 1 commit into from
Feb 11, 2016

Conversation

drewblaisdell
Copy link
Contributor

.logged-out-auth was removed from Calypso in Automattic/wp-calypso#2964, in favor of CSS that targets a specific section (e.g. .is-section-login).

Testing

  • Assert that the styles of the login screen remain unchanged (i.e. that the page isn't broken).

@drewblaisdell
Remove unused CSS
f2c1c70 
`.logged-out-auth` has been removed in favor of CSS that targets a
specific section (e.g. `.is-section-login`).
@drewblaisdell drewblaisdell self-assigned this Feb 10, 2016
@mjangda
Copy link
Member

mjangda commented Feb 11, 2016

LGTM. @jasmussen any concerns?

@jasmussen
Copy link
Member

screen shot 2016-02-11 at 09 07 37

Yep, looks good to me! Ship it!

@drewblaisdell
Copy link
Contributor Author

Thanks @mjangda / @jasmussen.

drewblaisdell added a commit that referenced this pull request Feb 11, 2016
@drewblaisdell
Merge pull request #79 from Automattic/remove/stale-css
9a42234 
Remove unused CSS
@drewblaisdell drewblaisdell merged commit 9a42234 into master Feb 11, 2016
@drewblaisdell drewblaisdell deleted the remove/stale-css branch February 11, 2016 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drewblaisdell drewblaisdell

Labels
[Status] Ready to Merge [Type] Task
Projects
None yet
Milestone
No milestone
4 participants
@drewblaisdell @mjangda @jasmussen @fabianapsimoes