-
Notifications
You must be signed in to change notification settings - Fork 20
Selecting wrong menu items #1530
Comments
This happened recently for 'People' page when I ran tests locally. It was failing randomly. |
I think we should try to avoid selecting menu items by text since they're translated and won't work in other languages, eg for i18n tests, and also menu text is more likely to change than a specific attribute. Or do I misunderstand something? |
1 similar comment
I think we should try to avoid selecting menu items by text since they're translated and won't work in other languages, eg for i18n tests, and also menu text is more likely to change than a specific attribute. Or do I misunderstand something? |
@alisterscott I replied to this comment here. So yes, data e2e attribute would be more stable solution. |
If you run the tests without retrying it's common to see the tests selecting the wrong item in the menu sidebar and then failing as the incorrect screen is shown
Something is funky with how we click these sidebar items - we should investigate why
To reproduce change
"max_test_attempts": 3,
to"max_test_attempts": 1,
inmagellan.json
and commit the change to see the failures in CircleCI for a branchThe text was updated successfully, but these errors were encountered: