This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Use about page instead of design type in signup tests #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/pages/signup/about-page.js
Outdated
| @@ -0,0 +1,15 @@ | |||
| import { By } from 'selenium-webdriver'; | |||
| import * as driverHelper from '../../driver-helper.js'; | |||
| import * as driverManager from '../../driver-manager.js'; | |||
There was a problem hiding this comment.
Is this line necessary?
|
|
markryall
force-pushed
the
add/new-signup-step
branch
from
d12d19c
to
e0dd04f
Compare
hoverduck
added a commit
that referenced
this pull request
Dec 20, 2017
This reverts commit e0c44bc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new about page step has been declared a winner in a signup a/b test as an alternative to the design type step.
Currently, 100% of en users are seeing this step instead of design type.
This change ensures the signup tests will be prepared for the likely permanent replacement of the design type step with this new step.