Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme: update example public key format #104

Merged
merged 1 commit into from Oct 26, 2023
Merged

Readme: update example public key format #104

merged 1 commit into from Oct 26, 2023

Commits on Oct 25, 2023

  1. Readme: update example public key format 

    Fixes #103

The readme suggests setting up keys in `wp-config.php`, and suggests using comments like `-----BEGIN RSA PUBLIC KEY-----` to clearly mark the beginning and end of your key.

However, that format:

1. Does not match the output of the `openssl` command.
2. Does not match the format we expect in Tools > Site Health: https://github.com/Automattic/wp-openid-connect-server/blob/ee663a12d9e12d0b5c9e8c7745c3b48c716754b2/src/SiteStatusTests.php#L35

Let's update the example format to match what's expected.
    @jeherve
    jeherve committed Oct 25, 2023
    Copy the full SHA
    aec3319 View commit details
    Browse the repository at this point in the history