New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it harder to use file locking because it's not really needed. #174

Merged
merged 2 commits into from Feb 1, 2017

Conversation

Projects
None yet
1 participant
@donnchawp
Contributor

donnchawp commented Feb 1, 2017

The plugin writes to files with random filenames and then renames those
files to their final cached filename which is an atomic action that
can't be interupted. The only reason to have this coarse locking is if
your server is so underpowered it can't cope with multiple processes
writing to files at the same time. This will slow down how fast new
files are cached significantly.
This patch changes the language on the settings page warning the user
that if will slow down their website.
The constant "WPSC_DISABLE_LOCKING" was used to hide the setting, but now
it's checked in each function that implements file locking.
sem_remove() seems to cause problems using semaphores so it is disabled
unless the constant "WPSC_REMOVE_SEMAPHORE" is defined.

Make it harder to use file locking because it's not really needed.
The plugin writes to files with random filenames and then renames those
files to their final cached filename which is an atomic action that
can't be interupted. The only reason to have this coarse locking is if
your server is so underpowered it can't cope with multiple processes
writing to files at the same time. This will slow down how fast new
files are cached significantly.
This patch changes the language on the settings page warning the user
that if will slow down their website.
The cosnstant "WPSC_DISABLE_LOCKING" was used to hide the setting, but now
it's checked in each function that implements file locking.
sem_remove() seems to cause problems using semaphores so it is disabled
unless the constant "WPSC_REMOVE_SEMAPHORE" is defined.

@donnchawp donnchawp added this to the 1.4.9 milestone Feb 1, 2017

@donnchawp donnchawp self-assigned this Feb 1, 2017

Updated the changelog and added docs on disabling file locking.
Added changelog entries for recent changes added and documentation
added to show hosts how to disable file locking globally.

@donnchawp donnchawp merged commit ddc92f5 into master Feb 1, 2017

@donnchawp donnchawp deleted the semaphore_cleanup branch Feb 1, 2017

kraftbj pushed a commit that referenced this pull request Feb 9, 2017

donncha
Sync with GITHUB:
* Don't delete so many files on blogs with static homepages. #175
* Discourage use of file locking because semaphores cause problems and it's not needed. #174
* Reorganise the settings page in small ways #173
* Fixed XSS in settings page. Props @jaypatel #172



git-svn-id: http://plugins.svn.wordpress.org/wp-super-cache/trunk@1587563 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment