/ wp-super-cache Public
Make it harder to use file locking because it's not really needed. #174
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
The plugin writes to files with random filenames and then renames those
files to their final cached filename which is an atomic action that
can't be interupted. The only reason to have this coarse locking is if
your server is so underpowered it can't cope with multiple processes
writing to files at the same time. This will slow down how fast new
files are cached significantly.
This patch changes the language on the settings page warning the user
that if will slow down their website.
The constant "WPSC_DISABLE_LOCKING" was used to hide the setting, but now
it's checked in each function that implements file locking.
sem_remove() seems to cause problems using semaphores so it is disabled
unless the constant "WPSC_REMOVE_SEMAPHORE" is defined.