Remove most calls to get_all_supercache_filenames() #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_all_supercache_filenames() is used to get a list of index.html type files for deleting. There are a number of duplicate foreach() loops in wp-cache-phase2.php that should be rolled into one function. This patch adds wpsc_delete_files() which takes a directory and deletes any files in that directory. This goes beyond what the foreach() loops did but also checks that the directory is in the cache directory so should be safe to use. It should make it easier to cache different types of pages and maintain them using this function.
This removes all files in a particular supercache directory when deleted from the settings page, rather than just the index.html types files.
Windows changes / to \ when paths go through realpath() so we need to apply realpath to all paths when there's a comparison.
This function will respect the rebuild setting in the function. The delete function will now also remove the directory after deleting all the files in the directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_all_supercache_filenames() is used to get a list of index.html type
files for deleting. There are a number of duplicate foreach() loops in
wp-cache-phase2.php that should be rolled into one function.
This patch adds wpsc_delete_files() which takes a directory and deletes
any files in that directory. This goes beyond what the foreach() loops
did but also checks that the directory is in the cache directory so
should be safe to use.
It should make it easier to cache different types of pages and maintain
them using this function.