Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fullwidth description to file_selector and file_download #984

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Add fullwidth description to file_selector and file_download #984

merged 2 commits into from
Jul 10, 2024

Conversation

Satoshi-Sh
Copy link
Contributor

Related Issue

Fixed #981

Updates

  • Added fullwidth description to the file_selector and file_download templates.

@trgiangdo trgiangdo added the 📈 Improvement Improvement of a feature. label Jun 11, 2024
@FlorianJacta
Copy link
Member

It seems great. Do you have a screenshot to see what the documentation will look like? (I am speaking about the documentation, not the file_selector)

@Satoshi-Sh
Copy link
Contributor Author

Here is the screenshot.

Screenshot from 2024-06-12 06-13-51

@FlorianJacta
Copy link
Member

Fantastic work! Like the other PR, as it touches the User Manual, it is blocked by this PR #940

But once merged, we can merge this PR also.

You did a great job as always!

@FlorianJacta FlorianJacta added 📄 Documentation Internal or public documentation ❌ Blocked Issue is blocked labels Jun 12, 2024
@Satoshi-Sh
Copy link
Contributor Author

Glad to hear that. Thanks for the guidance, Florian.

@jrobinAV jrobinAV self-requested a review June 17, 2024 10:32
@jrobinAV jrobinAV removed the ❌ Blocked Issue is blocked label Jun 17, 2024
FabienLelaquais
FabienLelaquais requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doc template files.

docs/manuals/gui/viselements/file_download.md_template Outdated Show resolved Hide resolved
docs/manuals/gui/viselements/file_download.md_template Outdated Show resolved Hide resolved
docs/manuals/gui/viselements/file_selector.md_template Outdated Show resolved Hide resolved
docs/manuals/gui/viselements/file_selector.md_template Outdated Show resolved Hide resolved
@FabienLelaquais
Copy link
Member

The issue was unblocked for it does not impact the manuals refactoring.

@Satoshi-Sh Satoshi-Sh force-pushed the feat/#981-add-fullwidth-property branch from d98ea18 to 4c6114f Compare June 17, 2024 11:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jul 8, 2024
FabienLelaquais
FabienLelaquais approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FlorianJacta FlorianJacta merged commit 97366cb into Avaiga:develop Jul 10, 2024
1 check passed
@jrobinAV jrobinAV added the ❌ Blocked Issue is blocked label Jul 10, 2024
@jrobinAV
Copy link
Member

blocked by #709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

@FlorianJacta FlorianJacta FlorianJacta approved these changes

@jrobinAV jrobinAV Awaiting requested review from jrobinAV

Assignees

@Satoshi-Sh Satoshi-Sh

Labels
❌ Blocked Issue is blocked 📄 Documentation Internal or public documentation 📈 Improvement Improvement of a feature. 🥶Waiting for contributor Issues or PRs waiting for a long time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add description for fullwidth property in file_selector and file_download
5 participants
@Satoshi-Sh @FlorianJacta @FabienLelaquais @jrobinAV @trgiangdo