npi validator should pass if value is empty, null or undefined

* fixes #184
Availity · Jan 23, 2016 · 3a836fc · 3a836fc
1 parent fe6899e
commit 3a836fc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/lib/core/validation/validators/tests/validator-npi-spec.js b/lib/core/validation/validators/tests/validator-npi-spec.js
@@ -10,10 +10,10 @@ describe('avValNpi', function () {
     avValNpi = _avValNpi_;
   }));
 
-  it('should NOT validate if NPI is empty, undefined or null', function () {
-    expect(avValNpi.validate(undefined)).toBe(false);
-    expect(avValNpi.validate('')).toBe(false);
-    expect(avValNpi.validate(null)).toBe(false);
+  it('should validate if NPI is empty, undefined or null', function () {
+    expect(avValNpi.validate(undefined)).toBe(true);
+    expect(avValNpi.validate('')).toBe(true);
+    expect(avValNpi.validate(null)).toBe(true);
   });
 
   it("should NOT validate if NPI contains non-digits", function() {

diff --git a/lib/core/validation/validators/validator-date-format.js b/lib/core/validation/validators/validator-date-format.js
@@ -13,6 +13,7 @@
         return avValUtils.isEmpty(value) || moment(value, format, true).isValid();
       }
     };
+
     return validator;
   });
 })(window);
diff --git a/lib/core/validation/validators/validator-npi.js b/lib/core/validation/validators/validator-npi.js
@@ -4,7 +4,7 @@
 
   var availity = root.availity;
 
-  availity.core.factory('avValNpi', function() {
+  availity.core.factory('avValNpi', function(avValUtils) {
 
 
     var validator =  {
@@ -17,6 +17,10 @@
 
         var npi = value || '';
 
+        if(avValUtils.isEmpty(npi)) {
+          return true;
+        }
+
         if (!validator.INTEGER_REGEX.test(npi) || npi.length !== 10) {
           return false;
         }