Set form validity when element is removed from a possibly invalid ele… #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +52,9 @@ | |||
| if(id && this.violations[id]) { | |||
| delete this.violations[id]; | |||
| } | |||
| if(_.isEmpty(this.violations)) { | |||
| this.ngForm.$setValidity('av', _.isEmpty(this.violations)); | |||
There was a problem hiding this comment.
you could just set it to true at this point instead of re-running the isEmpty check since it will have to truthy in order to hit this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the form validation that prevents a form from being submitted if an element has a violation is removed from the form. The form validity never resets. I added I check to set the validity in the unrecord method for an empty list of violations.