Removing babel-polyfill #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSharpieOne
requested changes
Mar 3, 2017
There was a problem hiding this comment.
You may want to remove it from the tests so that it will test/ensure that the library can run without it. Otherwise we are just not including it as a dep and requiring the client to add it to their package.
Ref: https://github.com/Availity/availity-angular/blob/master/src/specs.js#L2
robmcguinness
approved these changes
Mar 3, 2017
TheSharpieOne
approved these changes
Mar 3, 2017
|
@KaseyPowers I removed the |
|
I think the removing of polyfill ended up being independent of the workflow v2 stuff so if you two aren't confident in that change It should be removable. |
robmcguinness
approved these changes
Mar 11, 2017
| @@ -1,27 +1,4 @@ | |||
| import 'angular-shims-placeholder'; | |||
| import ngModule from '../module'; | |||
|
|
|||
| ngModule.requires.push('ng.shims.placeholder'); | |||
There was a problem hiding this comment.
Is this even needed anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this to prevent core-js from always being added to projects