Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs using cards #100

Merged
merged 48 commits into from
Sep 14, 2015
Merged

Conversation

robmcguinness
Copy link
Contributor

No description provided.

@robmcguinness
Copy link
Contributor Author

image

image

image

image

image

image

@@ -63,6 +91,29 @@
}
}

.card-header-link {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption is this will be used within .card-title. If so, can we use .card-title-link instead of header? We need consistent terminology.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm actually thinking the name shoudl be card-link-right...it can go in a .card-title or .card-header or .card-header-secondary. thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the distiction between .card-title and .card-header?
On Sat, Sep 12, 2015 at 3:22 PM robert mcguinness notifications@github.com
wrote:

In less/availity-cards.less
#100 (comment)
:

@@ -63,6 +91,29 @@
}
}

+.card-header-link {

i'm actually thinking the name shoudl be card-link-right...it can go in a
.card-title or card-header or card-header-secondary. thoughts?


Reply to this email directly or view it on GitHub
https://github.com/Availity/availity-uikit/pull/100/files#r39340538.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.card-header with a card-title in body of card

image

.card-title stanalone

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added .card-header-link and .card-title-link which basically do the same thing. would that be sufficient?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. That works
On Sat, Sep 12, 2015 at 4:01 PM robert mcguinness notifications@github.com
wrote:

In less/availity-cards.less
#100 (comment)
:

@@ -63,6 +91,29 @@
}
}

+.card-header-link {

I added .card-header-link and .card-title-link which basically do the
same thing. would that be sufficient?


Reply to this email directly or view it on GitHub
https://github.com/Availity/availity-uikit/pull/100/files#r39340863.

@robmcguinness
Copy link
Contributor Author

image

@robmcguinness
Copy link
Contributor Author

@bobbennett let me know when you have time to run through the code and see the demos. I think all the examples are updated now and looking a bit more fresh.

@bobbennett
Copy link
Contributor

Sizing example needs updated. .guide-example .card is overriding col-sm-6

@bobbennett
Copy link
Contributor

The "Pages" screen looks a little odd. The background doesn't fill the page and there is a scrollbar even though there is no scrolling content (due to main, .main: 1em;).

image

@bobbennett
Copy link
Contributor

I know you changed other things to use the select2 dropdown. The one on the "Payer Spaces Dashboard" needs it as well.

image

@robmcguinness
Copy link
Contributor Author

😎 ok i'll check it out

@bobbennett
Copy link
Contributor

I think I'm done. Aside from the couple of very minor things above, it all looks good. We need to keep an eye out for responsive .card-decks and .card-columns. It'll allow us to replace some of our existing styles. This is one of the issues I've found in bootstrap: twbs/bootstrap#17486

@robmcguinness
Copy link
Contributor Author

updated sizing example. the docs.less file restricts the card size for demo purposes. in the wild cards are block level by default. i'll check out the other issues

@robmcguinness
Copy link
Contributor Author

image

@robmcguinness robmcguinness changed the title Update docs with using cards Update docs using cards Sep 14, 2015
@robmcguinness
Copy link
Contributor Author

image

robmcguinness added a commit that referenced this pull request Sep 14, 2015
@robmcguinness robmcguinness merged commit cd5152f into develop Sep 14, 2015
@robmcguinness robmcguinness deleted the feature/update-docs-with-new-cards branch September 14, 2015 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants