-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs using cards #100
Conversation
* add card header link * add secondary header * remove padding to from card-block siblings
* remove margin of last child in card * add card-header-link
* they never looked good
* easier to build README by hand
Conflicts: less/availity-cards.less
@@ -63,6 +91,29 @@ | |||
} | |||
} | |||
|
|||
.card-header-link { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My assumption is this will be used within .card-title. If so, can we use .card-title-link instead of header? We need consistent terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm actually thinking the name shoudl be card-link-right
...it can go in a .card-title
or .card-header
or .card-header-secondary
. thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the distiction between .card-title and .card-header?
On Sat, Sep 12, 2015 at 3:22 PM robert mcguinness notifications@github.com
wrote:
In less/availity-cards.less
#100 (comment)
:@@ -63,6 +91,29 @@
}
}+.card-header-link {
i'm actually thinking the name shoudl be card-link-right...it can go in a
.card-title or card-header or card-header-secondary. thoughts?—
Reply to this email directly or view it on GitHub
https://github.com/Availity/availity-uikit/pull/100/files#r39340538.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added .card-header-link
and .card-title-link
which basically do the same thing. would that be sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. That works
On Sat, Sep 12, 2015 at 4:01 PM robert mcguinness notifications@github.com
wrote:
In less/availity-cards.less
#100 (comment)
:@@ -63,6 +91,29 @@
}
}+.card-header-link {
I added .card-header-link and .card-title-link which basically do the
same thing. would that be sufficient?—
Reply to this email directly or view it on GitHub
https://github.com/Availity/availity-uikit/pull/100/files#r39340863.
@bobbennett let me know when you have time to run through the code and see the demos. I think all the examples are updated now and looking a bit more fresh. |
* just use .card-block
Sizing example needs updated. |
😎 ok i'll check it out |
I think I'm done. Aside from the couple of very minor things above, it all looks good. We need to keep an eye out for responsive .card-decks and .card-columns. It'll allow us to replace some of our existing styles. This is one of the issues I've found in bootstrap: twbs/bootstrap#17486 |
updated sizing example. the docs.less file restricts the card size for demo purposes. in the wild cards are block level by default. i'll check out the other issues |
* update docs using cards * bug fixes
No description provided.