chore: add .nvmrc to set node version #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-a-young
requested review from
LauRoxx and
gregmartDOTin
as code owners
yarn.lock
Outdated
| @@ -4155,7 +4155,7 @@ boolbase@^1.0.0, boolbase@~1.0.0: | |||
| resolved "https://registry.yarnpkg.com/boolbase/-/boolbase-1.0.0.tgz#68dff5fbe60c51eb37725ea9e3ed310dcc1e776e" | |||
| integrity sha1-aN/1++YMUes3cl6p4+0xDcwed24= | |||
|
|
|||
| bootstrap@4.5.3, bootstrap@^4.3.1: | |||
| bootstrap@^4.3.1: | |||
There was a problem hiding this comment.
Should we use ^4.6.2? To ensure they're on latest?
There was a problem hiding this comment.
Good point. I can do that. That dependency refers to the docs. They use some features directly that weren't being used by the uikit. However, what I did copy into the uikit is 4.5.1
gregmartDOTin
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
bootstrapas a dependency and moves it inside of the uikit for support since bootstrap 4 is EOL. I added github actions workflows for PR builds and deploys once merged to master