Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-loader should not fail build #204

Closed
robmcguinness opened this issue Apr 12, 2019 · 4 comments · Fixed by #205
Closed

eslint-loader should not fail build #204

robmcguinness opened this issue Apr 12, 2019 · 4 comments · Fixed by #205

Comments

@robmcguinness
Copy link
Contributor

No description provided.

@nylon22 nylon22 self-assigned this Apr 12, 2019
@nylon22
Copy link
Member

nylon22 commented Apr 12, 2019

I don't think there's any way around this other than removing the eslint-loader. failOnWarning and failOnError are already defaulted to false.

https://github.com/webpack-contrib/eslint-loader#failonwarning-default-false
https://github.com/webpack-contrib/eslint-loader#failonerror-default-false

The quiet option only applies to warnings, not errors.

https://github.com/webpack-contrib/eslint-loader#quiet-default-false

So turns out, this issue is more of a nuisance than a problem.

@GoPro16
Copy link
Contributor

GoPro16 commented Apr 12, 2019

I wonder if the eslintrc file is not taking those eslint-loader options into consideration and are just overriding them.

@robmcguinness
Copy link
Contributor Author

@robmcguinness
Copy link
Contributor Author

module.exports = {
  loader: 'eslint-loader',
  exclude: /node_modules/,
  enforce: 'pre',
  test: /\.js?$/,
  options: {
    emitWarning: true, // <== tell webpack to emit warning
    baseConfig: {
      extends: 'eslint-config-availity'
    }
  }
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants