fix: relax rules. closes #249

Availity · Jul 29, 2021 · 3cf3e93 · 3cf3e93
1 parent d1a38c9
commit 3cf3e93
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/base.js b/base.js
@@ -64,6 +64,8 @@ module.exports = {
     'unicorn/import-index': 'off',
     'unicorn/filename-case': 'off',
     'unicorn/empty-brace-spaces': 0,
+    'unicorn/prefer-node-protocol': 0,
+    'unicorn/numeric-separators-style': ['error', { onlyIfContainsSeparator: true }],
     'unicorn/no-nested-ternary': 0,
     'unicorn/prefer-math-trunc': 0,
     'unicorn/no-null': 0,
@@ -76,6 +78,7 @@ module.exports = {
     'unicorn/no-array-reduce': 0,
     'import/no-extraneous-dependencies': 0,
     'no-plusplus': ['error', { allowForLoopAfterthoughts: true }],
+    'no-unused-vars': ['error', { ignoreRestSiblings: true }],
     'no-underscore-dangle': 0,
     'promise/avoid-new': 0,
     'prefer-destructuring': [

diff --git a/tests/base.js b/tests/base.js
@@ -3,12 +3,12 @@ module.exports = () => `
 var foo = function foo() {};
 foo()
 
+const number = 100000; // Pass, this number does not contains separators
 
-// no-unused-vars
-const arr = [
-  1,
-  2
-];
+// no-unused-vars ignore siblings
+const { ignoredAttribute , ...other } = {};
+
+console.log(other);
 
 // unicorn/import-index
 const conf = require('./');

diff --git a/tests/test.js b/tests/test.js
@@ -25,12 +25,17 @@ describe('rules', () => {
 
     const errors = runEslint(baseString(), baseConf);
 
+    const foundSibling = errors.some(
+      (element) => element.ruleId === 'no-unused-vars' && element.message.includes('ignoredAttribute')
+    );
+
     // Enabled
     expect(find(errors, { ruleId: 'no-var' })).toBeDefined();
     expect(find(errors, { ruleId: 'no-unused-vars' })).toBeDefined();
     expect(find(errors, { ruleId: 'unicorn/import-index' })).toBeUndefined();
 
     // Disabled
+    expect(foundSibling).toBe(false);
     expect(find(errors, { ruleId: 'no-param-reassign/sort-comp' })).toBeUndefined();
     expect(find(errors, { ruleId: 'prefer-destructuring' })).toBeUndefined();
     expect(find(errors, { ruleId: 'class-methods-use-this' })).toBeUndefined();
@@ -40,6 +45,7 @@ describe('rules', () => {
     expect(find(errors, { ruleId: 'unicorn/prefer-includes' })).toBeUndefined();
     expect(find(errors, { ruleId: 'unicorn/prefer-dom-node-remove' })).toBeUndefined();
     expect(find(errors, { ruleId: 'unicorn/prefer-dom-node-append' })).toBeUndefined();
+    expect(find(errors, { ruleId: 'unicorn/numeric-separators-style' })).toBeUndefined();
     expect(find(errors, { ruleId: 'unicorn/prefer-math-trunc' })).toBeUndefined();
     expect(find(errors, { ruleId: 'no-restricted-syntax' })).toBeUndefined();
     expect(find(errors, { ruleId: 'global-require' })).toBeUndefined();