Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement c4ids #3

Closed
mrjoshuak opened this issue Jan 8, 2016 · 4 comments
Closed

Implement c4ids #3

mrjoshuak opened this issue Jan 8, 2016 · 4 comments
Assignees
Labels

Comments

@mrjoshuak
Copy link
Contributor

Implement c4ids to satisfy the tests created in issue #2.

There is a file already in the project that implements c4ids that can be used as reference.

@mjaganathan
Copy link
Contributor

Joshua, could you brief on this issue. I hope you had seen the earlier issues there for review.

@mrjoshuak
Copy link
Contributor Author

See #2 for notes on pushing updates to GitHub.

@mjaganathan
Copy link
Contributor

Joshua, as per our understanding on description provided here we have committed the fix to repo, please review & provide comments.

@mrjoshuak
Copy link
Contributor Author

The basic c4 functionality is there (since it was already), but the tests don't appear to be running properly. I made some simple changes to get the tests to run but the tests don't pass. The id of test.mp4 file is:

c416bf4pkWQSfUfHizjSDzdtMqNLr93GWUQ1Pozu2gFqKyrfvXkge59yR4DHpQ6NodDHT48VwXMEXyfhigFXqFWUe2

But the tests are not updated with that test value so they don't pass.

You should use the reference implementation to discover the c4id of any file prior to testing. You can download the latest build from https://cccc.io/. Or build and run it from the golang source.

Also you needn't use a big (7.8M) mp4 file for testing. Any file will do. For example the c4id of a empty file is: c459CSJESBh38BxDwwxNFKTXE4cC9HASGe3bhtN6z58GbwLqpCyRaKyZSvBAvTdF5NpSTPdUMH4hHRJ75geLsB1Sfs

The c4id of your username mjaganathan is: c44NU5NWmBVRNGUzerAUKu9D8N8GnNGJjD2sWC92mjQU35ducJ4dYQvpQaDjh37kwBs6w8KP8Zg5iBLQtV5fGvNKu5

Anything of any size can be identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants