Exclude non-functional DatePicker from styles collection #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, thanks! |
|
I hope when 11 is stable, I get a chance to look at both DatePicker and TimePicker. And there are currently a few issues preventing Material.Avalonia from compiling with preview 6 as well. I could get Material.Avalonia to compile, but not the Demo because of upstream incompatibility, especially AvaloniaEdit. |
|
Yep, you can submit a PR for preview 6 support, if you want. I still planning to support this in near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Material DatePicker implementation is non-functional. However, the inclusion of the Material styles into a project heavily interferes with either providing a custom style for DatePicker, or just utilizing the Avalonia.Themes.Simple. The way <themes:MaterialTheme /> is structured, it is not possible to exclude styles for particular controls, and themes:BundledTheme isn't supported anymore. As such, the style declaration for DatePicker should be removed, until a time where both DatePicker and TimePicker have consistent and functional styling Material.Avalonia.