Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog Service #23

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Dialog Service #23

merged 6 commits into from
Jul 15, 2022

Conversation

DamianSuess
Copy link
Collaborator

@DamianSuess DamianSuess commented Jul 15, 2022 •
edited

IDialogService for v8.1.97

  • Implement DialogService
  • Create sample projects
  • Cleanup code

Ready for review

@DamianSuess DamianSuess self-assigned this Jul 15, 2022
@DamianSuess DamianSuess added the enhancement New feature or request label Jul 15, 2022
@DamianSuess DamianSuess marked this pull request as draft July 15, 2022 18:35
@DamianSuess
Copy link
Collaborator Author

Still need to cleanup the base window style to auto-adjust to the child content and clean-up the sample app

@DamianSuess DamianSuess marked this pull request as ready for review July 15, 2022 19:26
@DamianSuess DamianSuess linked an issue Jul 15, 2022 that may be closed by this pull request
Include the IDialogService Feature #20
Closed
@DamianSuess
Copy link
Collaborator Author

DamianSuess commented Jul 15, 2022 •
edited

@OmidID, the PR is ready for review. We got IDialogService! :)
With this feature nailed down, we've got a great candidate for the NuGet package

@OmidID OmidID merged commit 2ef27b9 into master Jul 15, 2022
@DamianSuess DamianSuess deleted the feature/IDialogService branch July 15, 2022 21:43
@DamianSuess
Copy link
Collaborator Author

Thank you!

@OmidID
Copy link
Collaborator

OmidID commented Jul 16, 2022

Maybe is the time to publish nuget packages.

@DamianSuess
Copy link
Collaborator Author

indeed my man. Do you want me to take care of this one, or do you got it?

@OmidID
Copy link
Collaborator

OmidID commented Jul 19, 2022

@DamianSuess Sorry. I was busy. I think it is late. Already you did it :D

@DamianSuess
Copy link
Collaborator Author

@OmidID no worries, I completely understand - we all got bills to pay 😆
I go so wrapped up in testing the new infrastructure, I forgot to reply back on this thread to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DamianSuess DamianSuess

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include the IDialogService Feature
2 participants
@DamianSuess @OmidID