Cleanup and Unit Test Repairs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecs. No longer need to define, `prism:ViewModelLocator.AutoWireViewModel="True"`
…() needed. Added remarks to PrismApplicationBase.
…g the missing feature in Avalonia 0.10.x
DamianSuess
commented
Nov 27, 2022
|
Ready for review |
|
Thank you @OmidID! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch initially set out to address some Unit Tests, and in the process ended up fixing
AutoWireViewModelto be enabled by default as per the Prism Library design.This PR is in preparation for Avalonia v0.11-pre migration.
Feature Includes:
ViewModelLocator.cs)PrismApplicationBaseFixturepreviously not callingInitialize()FrameworkElement(WPF) shim which wrappedAvalonia.Controls.Controlobject.AvaloniaObjectinstead of the lowerVisualobject. _Not a bug, just a consistency update`