Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge AvaloniaUI v0.10.4 into Master #8

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Merge AvaloniaUI v0.10.4 into Master #8

merged 4 commits into from
Aug 13, 2021

Conversation

DamianSuess
Copy link
Collaborator

This is a simple pull request which targets the latest AvaloniaUI v0.10.4 and upgrades the examples to use .NET 5.
Also, as a goodie, I've included the .editorconfig from PrismLibrary to stay compatible with their coding format.

@DamianSuess
Copy link
Collaborator Author

Tested locally with .NET 5 with success. Let me know if there is anything else required prior to the PR being accepted.

Just as an FYI, I'm looking into upgrading to Prism 8.1.92. Please let me know if this effort is already underway elsewhere.

@OmidID
Copy link
Collaborator

OmidID commented Aug 13, 2021

@DamianSuess Hello and thanks for the PR.
Unfortunately, the changes are faulty. All the dependencies and csproj files are organized in props files and this is not a correct way to update dependencies.
I have an article that I hope it is helpful, and you could create another PR following these rules.
https://omidid.com/topic/Howtoorganizeyourcsprojandlibrariesusingpropsfiles

@DamianSuess
Copy link
Collaborator Author

DamianSuess commented Aug 13, 2021

@OmidID Thank you, I'll take care of it right away
Is there anything else you noticed that is a miss?

@DamianSuess
Copy link
Collaborator Author

Ready for review 👍

@OmidID OmidID merged commit dbcbad6 into AvaloniaCommunity:master Aug 13, 2021
@DamianSuess
Copy link
Collaborator Author

awesome, thank you @OmidID

@DamianSuess DamianSuess deleted the feature-Avalonia104 branch July 22, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants