-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variable-height rows. #136
Conversation
Allow for cells to adjust their height based on the new width supplied when a second measure pass is run.
Scrolling with mousewheel seems to not be so happy when trying to scroll up from the bottom of the tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scrolling up to down is quite smooth! Although going in the opposite direction is jittery as @SCLDGit said
Yeah we need to adjust how
Either way, I think it's going to need changes to Avalonia itself. |
|
With latest algorithm from Avalonia's `VirtualizingStackPanel`.
Ok, this PR should now be ready. Scrolling is now smooth, though the scrollbar jerks about as with Avalonia's virtualization implementation. We'll need to implement better height estimation as discussed in AvaloniaUI/Avalonia#10892 but this should be quite usable now. |
Adds support for variable-height rows, and adds a Wikipedia example to the sample app to demonstrate.
Ports the virtualization algorithm from Avalonia's
VirtualizingStackPanel
.Fixes #43