Make switching between flat and tree layouts easier. #277
+209
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow easier switching between types of source.
AvaloniaUI/Avalonia#15075 breaks a test I'm currently writing.
Columns are initialized sized incorrectly.
Don't call `UpdateColumnSizes` when the viewport changes if no measure pass has been carried out yet.
|
@grokys we don't need this PR anymore. But probably you still want to merge it since this API helps anyone trying to use both flat/hierarchical rows in the future. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ItemsandSelectiononITreeDataGridSource: this allows one to more easily operate on both flat and tree sources using the same interfaceNote that this PR does not add a
RowSelectionorCellSelectionproperty toITreeDataGridSource, as it's envisioned that future sources will not want to expose these. Given that those properties are just castingSelectionto the relevant type, it's easy enough to do this using e.g. an extension method anyway if desired.