11.1.0-beta1 stackoverflow on property set (SetProperty), works in 11.0.10

[BobbyCannon]

Describe the bug

This code below is stack overflowing on 11.1.0-beta1. If I roll back to 11.0.10 the code works fine.

[Required(ErrorMessage = "Name is required!")]
public string Name
{
	get => _name;
	set => SetProperty(ref _name, value, true);
}

To Reproduce

Call ObservableValidator.SetProperty in 11.1.0-beta1 leads to stackoverflow.

[Required(ErrorMessage = "Name is required!")]

I think it's due to the required attribute but I'm not sure.

Expected behavior

The code should not stackoverflow?

Avalonia version

11.1.0-beta1

OS

Windows

Additional context

No response

[maxkatz6]

Stacktrace (of stackoverflow) and SetProperty implementation are required to help here. Or minimal repro project.

[laolarou726]

@BobbyCannon

I have the same issue, check if your App.axaml.cs's OnFrameworkInitializationCompleted() has following code:

BindingPlugins.DataValidators.RemoveAt(0);

@maxkatz6 Maybe consider adding this note in the Release message

[maxkatz6]

@laolarou726 what exactly should be added to the release message?

[laolarou726]

@laolarou726 what exactly should be added to the release message?

I mean this line of code. When I upgrading the Avalonia version for my older project. I also noticed this issue. After some investigation, I noticed this line of code has been added to the latest template project. So maybe add this notice some where in the document or Release message might be a good idea?

[timunie]

minimal repro to paste into src/Samples/Sandbox

        public MainWindow()
        {
            InitializeComponent();
            DataContext = new ViewModel();
        }

....

    public partial class ViewModel : ObservableValidator
    {
        // [Required(ErrorMessage = "Name is required!")] 
        [ObservableProperty] 
        [NotifyDataErrorInfo]
        private string? _Name;
    }

and

  <TextBox Text="{Binding Name}" />

---

seems to stuck around here:

[timunie]

... and here:

[BobbyCannon]

I had commented that line of code then removed it.

I was concerned about two things...

1. Why 0 index, what it that changes in an upgrade?
2. What was being removed.

This morning I wrote this...

// Removes {Avalonia.Data.Core.Plugins.DataAnnotationsValidationPlugin}
var found = BindingPlugins.DataValidators.FirstOrDefault(x => x is DataAnnotationsValidationPlugin);
if (found != null)
{
	BindingPlugins.DataValidators.Remove(found);
}

It won't break if the validator moves to a different location.

Also is this still just a bug with the DataAnnotationsValidationPlugin?

I noticed while debugging this value adds { Value: } around the previous value.

[timunie]

@BobbyCannon https://docs.avaloniaui.net/docs/guides/development-guides/data-validation#manage-validationplugins

However, this is still a regression imo, so keep this ticket open for now.