Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS: Multiple child window ordering is broken when closing child window #8878

Closed
grokys opened this issue Sep 1, 2022 · 0 comments · Fixed by #8880
Closed

MacOS: Multiple child window ordering is broken when closing child window #8878

grokys opened this issue Sep 1, 2022 · 0 comments · Fixed by #8880
Assignees
@grokys
Labels
bug os-macos

Comments

@grokys
Copy link
Member

grokys commented Sep 1, 2022

Describe the bug

On macOS, when one has multiple child windows, closing one of the children causes the other child to be moved behind the parent window until the parent window is clicked.

To Reproduce
Steps to reproduce the behavior:

  1. From main window W open two child windows A and B
  2. Close window B
  3. Window A is now displayed behind W

Expected behavior

Window A should be displayed in front of W.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: macOS
  • Version: 0.10.x and 11.0
@grokys grokys self-assigned this Sep 1, 2022
grokys added a commit that referenced this issue Sep 1, 2022
@grokys
Add failing test for #8878.
1c4a994 
And update the tests to use the value of `NSWindow.orderedIndex` exposed in 0cc0443 instead of relying on appium to give us a z-ordered list of windows.
grokys added a commit that referenced this issue Sep 1, 2022
@grokys
Don't bring old parent window to front.
b83b795 
When a window is closed, its parent window is set to null, which caused this code to run. This line caused the parent window to be brought to front, and should have also caused any other child windows to be brought to front, but it seems OSX ignored those requests, causing #8878.

Simply don't bring the parent window to the front when a child window is closed. I couldn't work out why this code was necessary anyway, and all integration tests still pass.

Fixes #8878.
@grokys grokys mentioned this issue Sep 2, 2022
Merged
grokys added a commit that referenced this issue Sep 2, 2022
@grokys
Don't bring old parent window to front.
c9afb8f 
When a window is closed, its parent window is set to null, which caused this code to run. This line caused the parent window to be brought to front, and should have also caused any other child windows to be brought to front, but it seems OSX ignored those requests, causing #8878.

Simply don't bring the parent window to the front when a child window is closed. I couldn't work out why this code was necessary anyway, and all integration tests still pass.

Fixes #8878.
grokys added a commit that referenced this issue Sep 2, 2022
@grokys
Don't bring old parent window to front.
ca79d1c 
When a window is closed, its parent window is set to null, which caused this code to run. This line caused the parent window to be brought to front, and should have also caused any other child windows to be brought to front, but it seems OSX ignored those requests, causing #8878.

Simply don't bring the parent window to the front when a child window is closed. I couldn't work out why this code was necessary anyway, and all integration tests still pass.

Fixes #8878.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grokys grokys

Labels
bug os-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

macOS: Fix child window order with multiple child windows AvaloniaUI/Avalonia
1 participant
@grokys