Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated packages used by tests #10210

Merged
merged 2 commits into from Feb 6, 2023
Merged

Updated packages used by tests #10210

merged 2 commits into from Feb 6, 2023

Conversation

jp2masa
Copy link
Contributor

@jp2masa jp2masa commented Feb 4, 2023

Changes

  • Updated packages used by tests
  • Fixed renderer test parameter type (it was nullable and inline data was int, and the conversion stopped working; the type was wrong anyway, because the pen couldn't be null)

@jp2masa jp2masa changed the title Updated packages used by tests. Updated packages used by tests Feb 4, 2023
@jp2masa
Copy link
Contributor Author

jp2masa commented Feb 4, 2023

The tests seem to be failing because the latest xunit.runner.visualstudio doesn't support net461, only net462. Would it be fine to update tests to net462?

@maxkatz6
Copy link
Member

maxkatz6 commented Feb 4, 2023

Would it be fine to update tests to net462?

Yes.

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0029618-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@jp2masa jp2masa marked this pull request as ready for review February 5, 2023 08:16
@maxkatz6 maxkatz6 merged commit a7f66bd into AvaloniaUI:master Feb 6, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0029688-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@jp2masa jp2masa deleted the package-updates-tests branch February 7, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jp2masa @maxkatz6 @avaloniaui-team