Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: Fix interaction between ExtendClientAreaToDecorationsHint and SystemDecorations #10677

Merged
merged 12 commits into from
Mar 16, 2023
Merged

macOS: Fix interaction between ExtendClientAreaToDecorationsHint and SystemDecorations #10677

merged 12 commits into from
Mar 16, 2023

Commits on Mar 13, 2023

  1. Add system decorations and extend client area opts

    @grokys
    grokys committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9845dfa View commit details
    Browse the repository at this point in the history

  2. Don't use a tuple for window chrome buttons. 

    Return a record so that we can add extra elements more easily.
    @grokys
    grokys committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d46eb22 View commit details
    Browse the repository at this point in the history

  3. Look up chrome buttons by a11y id. 

    XPath is slower, and unnecessary here.
    @grokys
    grokys committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2cce1d4 View commit details
    Browse the repository at this point in the history

  4. Don't get all window buttons when only one needed.

    @grokys
    grokys committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    7005333 View commit details
    Browse the repository at this point in the history

  5. Nullable fixes.

    @grokys
    grokys committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e378bce View commit details
    Browse the repository at this point in the history

  6. Fix platform fact/theory attributes. 

    Throwing on `Skip` setter was causing all subsequent tests in class to be ignored.
    @grokys
    grokys committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4c9bf8e View commit details
    Browse the repository at this point in the history

  7. Use correct window chrome elements.

    @grokys
    grokys committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    0a653b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Added failing tests for #10650.

    @grokys
    grokys committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d87e7fa View commit details
    Browse the repository at this point in the history

  2. Don't show titlebar when client area is extended. 

    Fixes first part of #10650.
    @grokys
    grokys committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    7c4b4db View commit details
    Browse the repository at this point in the history

  3. Only show traffic lights with full system decorations. 

    Fixes second part of #10650.
    @grokys
    grokys committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    142547a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fixes/10650-extend-client-area-decorations

    Dan Walmsley committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f75383c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Don't try to run macOS tests on Windows.

    @grokys
    grokys committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    456ddbb View commit details
    Browse the repository at this point in the history