Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text] Fixes #11294

Merged
merged 2 commits into from
May 17, 2023
Merged

[Text] Fixes #11294

merged 2 commits into from
May 17, 2023

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented May 9, 2023 •
edited

  • Fix TextLineImpl.GetCharacterHitFromDistance for lines that include a TextEndOfLine run
  • Fix overhang handling to prevent clipped text for slanted glyphs
  • Fix TextBox selection issues

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #11390
Fixes #11346
Fixes #11350
Fixes #6767

@Gillibald Gillibald changed the title [Text] Fixes [WIP][Text] Fixes May 9, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0034461-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0034563-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@robloo
Copy link
Contributor

robloo commented May 12, 2023

Without spending the time to test this, does this PR fix tooltip text measurements again? The below issue previously occurred several previews ago and then was fixed. Now it's back:

Too much margin/padding:
image

Cutting off last character:
image

@Gillibald
Copy link
Contributor Author

Without spending the time to test this, does this PR fix tooltip text measurements again? The below issue previously occurred several previews ago and then was fixed. Now it's back:

Too much margin/padding: image

Cutting off last character: image

@robloo How can I verify this?

@robloo
Copy link
Contributor

robloo commented May 16, 2023

How can I verify this?

Its the ColorPicker in ControlCatalog. If you click and hover over any color in the Palette tab it should appear.

You have to be using an English locale though as it just shows a processed version of the knowncolors enum. No localization infrastructure exists yet.

@Gillibald
Fix TextLineImpl.GetCharacterHitFromDistance for lines that include a…
f153c62 
… TextEndOfLine run

Fix overhang handling to prevent clipped text for slanted glyphs
Fix TextBox selection issues
@Gillibald Gillibald changed the title [WIP][Text] Fixes [Text] Fixes May 17, 2023
@maxkatz6 maxkatz6 enabled auto-merge May 17, 2023 04:45
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0034887-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue May 17, 2023
Merged via the queue into AvaloniaUI:master with commit 6b5ac0f May 17, 2023
6 checks passed
This was referenced Apr 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Gillibald @avaloniaui-team @robloo @maxkatz6