Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NotificationCard to determine the type of notification from an inherited INotification object #12103

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

Onebeld
Copy link
Contributor

@Onebeld Onebeld commented Jul 8, 2023

What does the pull request do?

Fixed a very small flaw where NotificationCard only defined the notification type from the Notification class, but not from the INotification interface, resulting in the notification type always remaining the default if the object is inherited from the interface.

What is the updated/expected behavior with this PR?

NotificationCard now takes all classes inherited from INotification to define the type of notification.

@Onebeld
Copy link
Contributor Author

Onebeld commented Jul 8, 2023

@Onebeld please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037548-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into AvaloniaUI:master with commit acff61d Aug 29, 2023
6 checks passed
@grokys grokys added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Oct 2, 2023
grokys pushed a commit that referenced this pull request Oct 2, 2023
Fix NotificationCard to determine the type of notification from an inherited INotification object
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants