New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ImportCompeted into ImportCompleted #12117
Rename ImportCompeted into ImportCompleted #12117
Conversation
@dotnet-policy-service agree |
@jgcodes2020 thanks! We support netstandard2.0 and that's why you can't use default interface implementations. Instead, you need to implement this member independently.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks good to me. I fixed CI build as well.
You can test this PR using the following package version. |
What does the pull request do?
This PR properly fixes issue #11960.
What is the current behavior?
The interface
Avalonia.Rendering.Composition.ICompositionImportedGpuObject
currently usesImportCompeted
for aTask
that completes when the import is completed.What is the updated/expected behavior with this PR?
Practically identical, except that name is fixed.
How was the solution implemented (if it's not obvious)?
ImportCompeted
was renamed toImportCompleted
. A separateImportCompeted
property was added that simply fetchesImportCompleted
. I have[Obsolete]
d theImportCompeted
property to encourage people to switch over to the new spelling.Checklist
Breaking changes
See Obsoletions/Deprecations section below.
Obsoletions / Deprecations
ICompositionImportedGpuObject.ImportCompeted
is obsoleted (since it's a typo). The replacement isImportCompleted
.I have yet to discuss with the core team. (@grokys @kekekeks @danwalmsley)
Fixed issues
Fixes #11960