Handle ScrollContentPresenter extent rounding errors #12256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
force-pushed
the
fixes/scroll-fp-error
branch
from
d6d0c3e
to
515e084
Compare
|
You can test this PR using the following package version. |
grokys
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
After the fix in #11916, there are still situations where the scrollbar shows unnecessarily, due to floating point rounding errors. #12232 has an exemple with a viewport height of 176.0 but an extent height of 176.00000000000003.
After this PR, if the extent and viewport are within
LayoutEpsilonof each other, the viewport is used instead.A unit test has been added.
Fixed issues
Fixes #12232