Updated ToggleSplitButton.IsChecked to bind TwoWay by default, same as ToggleButton. #12584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
robloo
reviewed
Aug 18, 2023
|
Thanks! This was missed with the initial port. |
maxkatz6
approved these changes
Aug 18, 2023
|
You can test this PR using the following package version. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Changes the
ToggleSplitButton.IsCheckedproperty to bindTwoWayby default.What is the current behavior?
It was binding one way by default.
What is the updated/expected behavior with this PR?
It should be binding two way by default, same as the similar
ToggleButtonalready does.How was the solution implemented (if it's not obvious)?
Changed prop def.
Checklist
N/A.
Breaking changes
The only break would be if someone wanted to have one way bind behavior (old default). But that's not typically expected with a toggle button.
Obsoletions / Deprecations
None.
Fixed issues
None.