Fix for AccessText underlines being very blurry #12634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
Gillibald
reviewed
Aug 23, 2023
Gillibald
approved these changes
Aug 23, 2023
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
Fix for AccessText underlines being very blurry
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Updates
AccessText.RenderCorelogic to align the rendered underline to pixel bounds for clarity.What is the current behavior?
The
DrawLinemethod was rendering at non-pixel bounds, which made lines very blurry.This simple XAML shows blurry underlines:
What is the updated/expected behavior with this PR?
Now lines render crisply like this:
How was the solution implemented (if it's not obvious)?
Rounded line coordinates to render on pixel bounds.
Checklist
N/A
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
None