Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inlines TextTrimming with embedded controls #12695

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Aug 28, 2023

What does the pull request do?

This PR makes sure visual children added via InlineUIContainer are properly cleaned up when text was trimmed

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038932-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald changed the title [WIP] Fix Inlines TextTrimming with embedded controls Fix Inlines TextTrimming with embedded controls Aug 30, 2023
Copy link
Collaborator

@wieslawsoltes wieslawsoltes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great!

@Gillibald Gillibald added this pull request to the merge queue Aug 31, 2023
Merged via the queue into AvaloniaUI:master with commit 3cd6c32 Aug 31, 2023
6 checks passed
@Gillibald Gillibald deleted the fixes/inlinesTrimming branch August 31, 2023 09:48
@Gillibald Gillibald added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Oct 2, 2023
grokys pushed a commit that referenced this pull request Oct 2, 2023
Fix Inlines TextTrimming with embedded controls
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants