Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac] Fixes raw keyDown/textInput handling #12774

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Sep 4, 2023

What does the pull request do?

This PR preserves the order of keyDown/textInput processing but still allows the current IME to consume keyDown events.

_lastKeyHandled no longer prevents keyDown events. It is now only used for some internal state.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes: #12571

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039155-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@BAndysc
Copy link
Contributor

BAndysc commented Sep 4, 2023

I had a bug in my app after migrating to Avalonia 11 related to the event order, which was fixed by #12560. Does it mean the user code has to take into account that the order of the events might be different depending on the platform?

@Gillibald Gillibald changed the title [Mac] IME fixes [WIP][Mac] IME fixes Sep 4, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039161-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald changed the title [WIP][Mac] IME fixes [Mac] IME fixes Sep 4, 2023
@Gillibald Gillibald changed the title [Mac] IME fixes [Mac] Fixes raw keyDown/textInput handling Sep 4, 2023
@Gillibald
Copy link
Contributor Author

I could find a way to preserve event order and still support consuming keyDown events by IME

Order is still:

PreviewKeyDown
KeyDown
PreviewTextInput
TextInput

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039165-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@kekekeks kekekeks added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Sep 19, 2023
@Gillibald Gillibald added this pull request to the merge queue Sep 20, 2023
Merged via the queue into AvaloniaUI:master with commit c1ab50b Sep 20, 2023
6 checks passed
@Gillibald Gillibald deleted the fixes/macIME branch September 20, 2023 11:25
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use Tab/Enter in IME candidates list
6 participants