-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mac] Fixes raw keyDown/textInput handling #12774
Conversation
You can test this PR using the following package version. |
I had a bug in my app after migrating to Avalonia 11 related to the event order, which was fixed by #12560. Does it mean the user code has to take into account that the order of the events might be different depending on the platform? |
You can test this PR using the following package version. |
88040bb
to
01d25d8
Compare
I could find a way to preserve event order and still support consuming keyDown events by IME Order is still: PreviewKeyDown |
You can test this PR using the following package version. |
What does the pull request do?
This PR preserves the order of keyDown/textInput processing but still allows the current IME to consume keyDown events.
_lastKeyHandled
no longer prevents keyDown events. It is now only used for some internal state.What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes: #12571