fix: DataGrid scroll should behave the same as ScrollViewer #12787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the user holds [Shift], we need to swap e.Delta (e.g. on Windows) if not already done by the OS (e.g. using Mac).
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Sep 6, 2023
timunie
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
if the user holds [Shift], we need to swap e.Delta (e.g. on Windows) if not already done by the OS (e.g. using Mac).
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Makes sure scrolling on DataGrid behaves the same as "normal"
ScrollViewer.What is the current behavior?
Holding
[Shift]doesn't scroll horizontally on DataGrid (at least using Windows 11). This was fixed before by #7520 but was lost during code refractor.What is the updated/expected behavior with this PR?
Scrolling behaves the same on every control and OS. Holding
[Shift]will scroll horizontallyHow was the solution implemented (if it's not obvious)?
copied the needed code from
ScrollContentPresenterChecklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
None as far as I can see