Fixes font family definitions that mix embedded and system fonts #12871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gillibald
changed the title
… of system and embedded fonts can be used
Gillibald
force-pushed
the
fixes/embeddedFontFallbacks
branch
from
429da52
to
c42a1cf
Compare
|
You can test this PR using the following package version. |
|
@Gillibald - I just tested the updates and both problems in #12806 appear to be resolved with this PR. Thank you! |
grokys
approved these changes
Sep 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
… of system and embedded fonts can be used (#12871)
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR introduces a way to store multiple font sources in within the FontFamilyKey object. This is needed to be able to mix embedded and system installed fonts in a fallback sequences.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
A CompositeFontFamilyKey was introduced that holds multiple keys that were created from the original FontFamily definition.
System fonts a represented by the systemfont: scheme everything else that needed a key previously is unchanged.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes: #12806