Trimmable runtime xaml loader #12937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
MrJul
reviewed
Sep 27, 2023
src/Markup/Avalonia.Markup.Xaml.Loader/CompilerDynamicDependencies.cs
Outdated
Show resolved
Hide resolved
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
MrJul
approved these changes
Sep 30, 2023
danwalmsley
added
the
backport-candidate-11.0.x
danwalmsley
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Add trimming attributes to the Runtime XAML Loader project * Create CompilerDynamicDependenciesAttribute with all known dynamic types * Use master XamlX * Implement CompilerDynamicDependenciesGenerator to simplify CompilerDynamicDependencies attribute * Better formatting of generated code * Be safe about type converters as well * Remove unnecessary warning * Also include FindType just in case
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Makes trimmed application to not crash while using runtime XAML parser.
How was the solution implemented (if it's not obvious)?
One of the solutions was to use
DynamicallyAccessedMembersattribute onTypeSystem.FindType(string)members, but it requires adding the assembly full name to each type, which is undesirable.Instead,
DynamicDependencyattribute for each known runtime type dependency was added.Fixed issues
Fixes #12419