Added guards for compositor reentrancy and exposed batch lifetime events #12968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
grokys
reviewed
Sep 21, 2023
| /// <summary> | ||
| /// Returns a task awaitable that would invoke continuation on specified dispatcher priority | ||
| /// </summary> | ||
| public DispatcherPriorityAwaitable AwaitWithPriority(Task task, DispatcherPriority priority) => |
There was a problem hiding this comment.
Interesting, can this be used like JoinableTaskFactory.SwitchToMainThreadAsync in VS? Like this example?
There was a problem hiding this comment.
Yes, it can be used from background threads too.
maxkatz6
approved these changes
Sep 22, 2023
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
…nts (#12968) * Added guards for compositor reentrancy and exposed batch lifetime events * Use manual continue with since our tests are using some borked sync context
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
…nts (#12968) * Added guards for compositor reentrancy and exposed batch lifetime events * Use manual continue with since our tests are using some borked sync context
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
stepangovorko
pushed a commit
to JetBrains/Avalonia
that referenced
this pull request
Oct 23, 2023
…nts (AvaloniaUI#12968) * Added guards for compositor reentrancy and exposed batch lifetime events * Use manual continue with since our tests are using some borked sync context (cherry picked from commit 96d2ea4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have reports about a problem caused by reentrancy in our rendering code.
Those are hard to diagnose, since reported exception is thrown way after said reentrancy happened.
This PR:
Those won't necessary fix the issue, but at least we'll get a proper stack trace.