Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XAML name generator with non-Avalonia XAML files #13001

Merged
merged 3 commits into from Sep 23, 2023
Merged

Fix XAML name generator with non-Avalonia XAML files #13001

merged 3 commits into from Sep 23, 2023

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

AdditionalFiles metadata was previously ignored.

Fixed issues

Fixes #12855
Fixes #12841 (unrelated, but also fixed)

@maxkatz6 maxkatz6 added area-xaml backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Sep 23, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039845-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Sep 23, 2023
Merged via the queue into master with commit 292d7ac Sep 23, 2023
7 checks passed
@maxkatz6 maxkatz6 deleted the fix-maui-xaml-with-analyzers branch September 23, 2023 09:51
grokys pushed a commit that referenced this pull request Oct 2, 2023
@maxkatz6 @grokys
Fix XAML name generator with non-Avalonia XAML files (#13001)
29bc00e 
* Fix #12841 by not putting stacktrace in the error message

* Respect SourceItemGroupMetadata to fix #12855

* Fix Generators.Sandbox
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kekekeks kekekeks kekekeks approved these changes

Assignees
No one assigned
Labels
area-analyzers area-xaml backported-11.0.x
Projects
None yet
Milestone
No milestone
4 participants
@maxkatz6 @avaloniaui-team @kekekeks @grokys