Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TransitioningContentControl to be reversed. #13003

Merged
merged 5 commits into from Oct 31, 2023
Merged

Allow TransitioningContentControl to be reversed. #13003

merged 5 commits into from Oct 31, 2023

Conversation

Alshain01
Copy link
Contributor

What does the pull request do?

Adds the ability to set a boolean property on TransitioningContentControl that will reverse the transition direction.

What is the current behavior?

The transition always goes "forward".

What is the updated/expected behavior with this PR?

The transition will animate in the opposite direction if the IsTransitionReversed property is true. The ":reversed" pseudoclass is also set on the control. Also, the ControlCatalog was updated to reflect the changes. (Will have no visual effect on CrossFade transition.)

How was the solution implemented (if it's not obvious)?

It's pretty obvious.

Checklist

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

#12442

@Alshain01 Alshain01 changed the title Allow TransitioningContentControl to be reversed. (#12442) Allow TransitioningContentControl to be reversed. Sep 23, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039873-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039883-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Alshain01
Copy link
Contributor Author

@dotnet-policy-service agree

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039921-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0040268-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0040303-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Alshain01 Alshain01 requested a review from grokys October 6, 2023 03:08
@maxkatz6 maxkatz6 added this pull request to the merge queue Oct 31, 2023
@maxkatz6
Copy link
Member

Thank you!

Merged via the queue into AvaloniaUI:master with commit e3c8e37 Oct 31, 2023
6 checks passed
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Jan 19, 2024
maxkatz6 added a commit that referenced this pull request Feb 8, 2024
@Alshain01 @maxkatz6
Allow TransitioningContentControl to be reversed. (#13003)
cf8b072 
* Allow TransitioningContentControl to be reversed. (#12442)

* Fix incorrect property name.

* Add missing pseudoclass attribute.

* Remove reversed transition pseudo class as discussed in review.

* Update samples/ControlCatalog/ViewModels/TransitioningContentControlPageViewModel.cs

Co-authored-by: Max Katz <maxkatz6@outlook.com>

---------

Co-authored-by: Max Katz <maxkatz6@outlook.com>
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

@grokys grokys Awaiting requested review from grokys

Assignees
No one assigned
Labels
backported-11.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Alshain01 @avaloniaui-team @maxkatz6 @grokys