[nuke] Use a regex to detect a release branch. #13106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the suggested regex from semver.org.
grokys
added
area-infrastructure
|
You can test this PR using the following package version. |
|
Gah, used the branch I was using for testing instead of the feature branch (they're both at the same HEAD commit). Oh well, the branch will get deleted if it gets merged. |
danwalmsley
approved these changes
Oct 2, 2023
grokys
added a commit
that referenced
this pull request
Oct 3, 2023
Using the suggested regex from semver.org.
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our nuke build system uses a simple
Branch.StartsWith("refs/heads/release/")check to detect if the current branch is a release branch. If a release branch is detected, the CI system doesn't append-cibuildXXXXXXXto the version number and instead preserves the version as defined inbuild/SharedVersion.props.The problem is that we want to be able to use branches with names such as
release/11.0to track the 11.0.x branch, but these branches are being detected as release branches even though the version number is incomplete.(Previously we used the
stable/0.10.xbranch naming scheme but it would be preferable to userelease/instead ofstable/now that both our minor and patch version numbers are technically "stable")This PR changes the release branch detection code to use a regex (taken from semver.org) to detect whether the current branch is a valid semver version.